Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail-safe API #66

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Fail-safe API #66

merged 5 commits into from
Jun 27, 2023

Conversation

Pythongor
Copy link
Contributor

There are 3 scenarios when app crashes:

  1. Automatic1111 webUI hasn't started
  2. Automatic1111 webUI has started but the SD or ControlNet API has not yet launched
  3. Automatic1111 webUI internal error

App just raises ConnectionError and crashes. I create class to handle all requests, check connection and if none return 503 response. For the moment it just saves app from crash, there is no further handling in views, so this will be next step

@Pythongor Pythongor marked this pull request as ready for review June 25, 2023 18:58
@Danamir Danamir changed the base branch from main to develop June 27, 2023 07:47
@Danamir
Copy link
Collaborator

Danamir commented Jun 27, 2023

Thanks, this will be useful.

Merging to develop before main, to do some testing.

@Danamir Danamir merged commit 503e88a into houseofsecrets:develop Jun 27, 2023
@Danamir Danamir mentioned this pull request Jun 27, 2023
@Pythongor Pythongor deleted the refactoring branch July 14, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants