Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make open team sheets data populate the battle object #660

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

cameronangliss
Copy link
Contributor

@cameronangliss cameronangliss commented Dec 8, 2024

Fixes #609

@cameronangliss cameronangliss marked this pull request as draft December 9, 2024 22:44
@hsahovic hsahovic force-pushed the master branch 2 times, most recently from 7d8bd5b to 524b047 Compare December 10, 2024 01:36
@cameronangliss cameronangliss force-pushed the open-sheets-fill-battle-obj branch from 9c3ae09 to 0572dff Compare December 15, 2024 09:32
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 28.26087% with 33 lines in your changes missing coverage. Please review.

Project coverage is 84.70%. Comparing base (f458350) to head (3b1d398).
Report is 110 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
+ Coverage   83.38%   84.70%   +1.31%     
==========================================
  Files          39       42       +3     
  Lines        3918     4432     +514     
==========================================
+ Hits         3267     3754     +487     
- Misses        651      678      +27     

cameronangliss added a commit to cameronangliss/poke-env that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open team sheets toggled on doesn't augment battle object automatically
1 participant