Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebuilding tokenizers for Mac M1. #932

Closed
Narsil opened this issue Mar 1, 2022 · 4 comments · Fixed by #1055
Closed

Prebuilding tokenizers for Mac M1. #932

Narsil opened this issue Mar 1, 2022 · 4 comments · Fixed by #1055
Milestone

Comments

@Narsil
Copy link
Collaborator

Narsil commented Mar 1, 2022

We're at this point waiting for GH actions to support M1 runners.

Any help to do it differently is appreciated, but for now we will probably resolve to manual builds on a M1 computer we have as cross compilation is rendered hard because of both the CPP dependencies we have, and the PyO3 compatibility requirements (which would require us to cross compile Python too).

@McPatate
Copy link
Member

McPatate commented Mar 1, 2022

Hey, I've added a few binaries for 0.11.6. Feedback is welcome to see if everything works as expected !

@almostintuitive
Copy link

@McPatate : It works, thank you! would it be possible to automatically add it to all subsequent releases?

@McPatate
Copy link
Member

McPatate commented Apr 22, 2022

We're waiting for the M1 GitHub actions runners to add it to our CI.

Will build manually for the time being as it's less hassle.

@moinnadeem
Copy link

Any luck doing this automatically? I think the latest release also requires Rust to build tokenizers, since prebuilt wheels for the M1 aren't available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants