Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/custom themes #1409

Merged
merged 85 commits into from
Feb 16, 2025
Merged

Feature/custom themes #1409

merged 85 commits into from
Feb 16, 2025

Conversation

Hachi-R
Copy link
Collaborator

@Hachi-R Hachi-R commented Jan 19, 2025

this pr add the possibility of create, import, edit and manage custom themes

@Hachi-R Hachi-R marked this pull request as draft January 19, 2025 00:36
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR migrates the application's styling system from CSS-in-JS (vanilla-extract) to SCSS to support custom theme functionality.

  • Added new customStyles field in settings-general.tsx but implementation is incomplete - value is stored but not used for theme application
  • Potential accessibility issues with hardcoded colors in new SCSS files (e.g. link.scss using #c0c1c7) instead of theme variables
  • Backdrop blur effects in backdrop.scss may cause performance issues on lower-end devices
  • Container query in profile-content.css.ts uses hardcoded 'app-container' string instead of imported variable
  • Toast component positioning relies on hardcoded bottom panel height (26px) which could break if panel height changes

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

46 file(s) reviewed, 49 comment(s)
Edit PR Review Bot Settings | Greptile

src/renderer/src/components/backdrop/backdrop.scss Outdated Show resolved Hide resolved
src/renderer/src/components/backdrop/backdrop.scss Outdated Show resolved Hide resolved
src/renderer/src/components/backdrop/backdrop.scss Outdated Show resolved Hide resolved
src/renderer/src/app.scss Outdated Show resolved Hide resolved
src/renderer/src/app.scss Outdated Show resolved Hide resolved
src/renderer/src/components/toast/toast.scss Outdated Show resolved Hide resolved
src/renderer/src/pages/settings/settings-general.tsx Outdated Show resolved Hide resolved
src/renderer/src/pages/settings/settings-general.tsx Outdated Show resolved Hide resolved
src/renderer/src/components/toast/toast.tsx Outdated Show resolved Hide resolved
src/renderer/src/scss/globals.scss Outdated Show resolved Hide resolved
Hachi-R and others added 28 commits January 23, 2025 15:23

Unverified

This user has not yet uploaded their public signing key.
…her/hydra into feature/custom-themes

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
…her/hydra into feature/custom-themes

Unverified

This user has not yet uploaded their public signing key.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Hachi-R and others added 26 commits February 16, 2025 16:10
Copy link
Contributor

@thegrannychaseroperation thegrannychaseroperation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thegrannychaseroperation thegrannychaseroperation merged commit e0dc87a into main Feb 16, 2025
4 checks passed
@thegrannychaseroperation thegrannychaseroperation deleted the feature/custom-themes branch February 16, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants