-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/custom themes #1409
Feature/custom themes #1409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR migrates the application's styling system from CSS-in-JS (vanilla-extract) to SCSS to support custom theme functionality.
- Added new
customStyles
field in settings-general.tsx but implementation is incomplete - value is stored but not used for theme application - Potential accessibility issues with hardcoded colors in new SCSS files (e.g. link.scss using #c0c1c7) instead of theme variables
- Backdrop blur effects in backdrop.scss may cause performance issues on lower-end devices
- Container query in profile-content.css.ts uses hardcoded 'app-container' string instead of imported variable
- Toast component positioning relies on hardcoded bottom panel height (26px) which could break if panel height changes
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
46 file(s) reviewed, 49 comment(s)
Edit PR Review Bot Settings | Greptile
Merge branch 'feature/custom-themes' of https://github.com/hydralaunc…
…her/hydra into feature/custom-themes
…a into feature/custom-themes
…a into feature/custom-themes
…a into feature/custom-themes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
this pr add the possibility of create, import, edit and manage custom themes