Resolve issue in which only first round would be docker-monitored #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Soelman <info@marksoelman.nl>
c7b30b2 to
61410f3
Compare
|
thanks for the contribution - you will need to sign off the commit before we can merge (DCO bot rules) and once we can figure out the issue in the pipeline with the Ethereum adaptor, we can merge it in |
Signed-off-by: Viserius <info@marksoelman.nl>
11532fa to
550fdb7
Compare
|
Thank you for highlighting this, I had not seen that! |
nklincoln
approved these changes
Jun 6, 2021
|
@aklenik - Seems the azure re-run builds is not working at the moment - i'm happy for this to go in "as is" and with the ethereum failure based on the fact that the other integration tests would have used this code change |
fraVlaca
pushed a commit
to fraVlaca/caliper
that referenced
this pull request
Sep 15, 2021
…er-monitor-rounds Resolve issue in which only first round would be docker-monitored Signed-off-by: fraVlaca <ocsenarf@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue that docker containers are only monitored during the first round of a multi-round benchmark as described in issue #1134.
The problem is caused by the fact that the
stop()command sets thethis.containersproperty to the empty array[], while it expects anullvalue to (re)set the containers list. By setting this toif (!this.containers || this.containers.length == 0), we account for both cases.Resolves #1134