Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross-process error message format #125

Merged

Conversation

aklenik
Copy link
Contributor

@aklenik aklenik commented Jul 12, 2018

If an unhandled exception occurred in a client process, the main process printed the received error object as the following, obscuring the original error. Set an invalid callback name to reproduce it:

not ok 5 failed 'open' testing, Error: Client encountered error:[object Object] at ChildProcess.<anonymous>

Now it receives the string version of the error and prints it correctly:

not ok 5 failed 'open' testing, Error: Client encountered error:Error: Cannot find module '/home/klenik/projects/caliper-single-org/benchmark/simple/opennn.js' at ChildProcess.<anonymous>

Signed-off-by: Attila Klenik a.klenik@gmail.com

Signed-off-by: Attila Klenik <a.klenik@gmail.com>
@haojun haojun merged commit d250698 into hyperledger-caliper:master Jul 13, 2018
@aklenik aklenik deleted the fix-cross-process-error-message branch July 13, 2018 06:46
faustovanin pushed a commit to faustovanin/caliper that referenced this pull request Oct 27, 2023
Update simpletest.go to fix incorrect error judgement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants