-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage mandatory metric #3
Comments
@bhack I don't understand exactly. Could you elaborate more? |
In the readme scheduler_warmup.step() is without parameters but I think that at https://github.com/ildoonet/pytorch-gradual-warmup-lr/blob/master/warmup_scheduler/scheduler.py#L54 metric cannot be none. |
The parameter 'epoch' can be none. Also I fix some bugs when epoch parameter is provided. |
We still need to send Metric param right? https://github.com/ildoonet/pytorch-gradual-warmup-lr/blob/master/warmup_scheduler/scheduler.py#L60 |
YES, If you use ReduceLROnPlateau(https://pytorch.org/docs/stable/optim.html#torch.optim.lr_scheduler.ReduceLROnPlateau). But No, if you use other schedulers(eg. cosine annealing) after gradual warmup. I'll update readme accordingly. |
Is in the usage example required a mandatory metric param?
https://github.com/ildoonet/pytorch-gradual-warmup-lr#usage
The text was updated successfully, but these errors were encountered: