Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage mandatory metric #3

Closed
bhack opened this issue Jun 8, 2019 · 5 comments
Closed

Usage mandatory metric #3

bhack opened this issue Jun 8, 2019 · 5 comments

Comments

@bhack
Copy link

bhack commented Jun 8, 2019

Is in the usage example required a mandatory metric param?
https://github.com/ildoonet/pytorch-gradual-warmup-lr#usage

@ildoonet
Copy link
Owner

ildoonet commented Jun 9, 2019

@bhack I don't understand exactly. Could you elaborate more?

@bhack
Copy link
Author

bhack commented Jun 9, 2019

In the readme scheduler_warmup.step() is without parameters but I think that at https://github.com/ildoonet/pytorch-gradual-warmup-lr/blob/master/warmup_scheduler/scheduler.py#L54 metric cannot be none.

ildoonet added a commit that referenced this issue Jun 10, 2019
ildoonet added a commit that referenced this issue Jun 10, 2019
@ildoonet
Copy link
Owner

The parameter 'epoch' can be none.

Also I fix some bugs when epoch parameter is provided.

@bhack
Copy link
Author

bhack commented Jun 12, 2019

@ildoonet
Copy link
Owner

YES, If you use ReduceLROnPlateau(https://pytorch.org/docs/stable/optim.html#torch.optim.lr_scheduler.ReduceLROnPlateau).

But No, if you use other schedulers(eg. cosine annealing) after gradual warmup.

I'll update readme accordingly.

ildoonet added a commit that referenced this issue Jun 14, 2019
@bhack bhack closed this as completed Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants