Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception on quality gate fail/error status at plugin level instead of sonar scanner #24

Merged
merged 3 commits into from
Mar 22, 2022

Conversation

softreigns
Copy link

  1. Since the plugin requires the sonar param sonar.qualitygate.wait=false to run in a fail case, where if it true the scan waits and fails before the plugin can run.
    ref: Failing a pipeline job when the Quality Gate fails

    Hence adding a parameter at plugin level to be able to run the plugin and still be able to fail the scan job.

  2. Update gitlab-ci with the latest.

@javamachr javamachr merged commit ffa433b into javamachr:master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants