Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(updatecli): Duplicate file path in targets configuration. #1958

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

gounthar
Copy link
Contributor

@gounthar gounthar commented Nov 27, 2024

This is a follow-up to PR #1955, as there appears to be a typo in it, involving a repeated file path.

Testing done

updatecli diff --config ./updatecli/updatecli.d/git-lfs.yaml --values ./updatecli/values.github-a
ction.yaml 2>&1

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@gounthar gounthar requested a review from a team as a code owner November 27, 2024 08:53
Copy link
Contributor

@lemeurherveCB lemeurherveCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

Thx!

@dduportal dduportal changed the title fix(updatecli): Duplicate file path in targets configuration. chore(updatecli): Duplicate file path in targets configuration. Nov 27, 2024
@dduportal dduportal merged commit 1c58b2e into jenkinsci:master Nov 27, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants