Bug/fix minor bugs #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the get_dns_record_ip function to retrieve the dns record id, current proxy status, and IP address from Cloudflare's API. It also adds an api_validation function to validate the response from the API.
This commit refactors the update-cloudflare-records.sh script to allow enabling or disabling of IPv4 and IPv6 for each domain. The get_domain_settings function now sets enable_ipv4 and enable_ipv6 instead of domain_ipv4 and domain_ipv6, respectively. The get_ip function now takes in enable_ipv4 and enable_ipv6 as arguments instead of domain_ipv4 and domain_ipv6. Finally, the get_dns_record_ip function checks if enable_ipv4 or enable_ipv6 is true before attempting to read A or AAAA records from Cloudflare's API, respectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12 and more