fix memory leak #190
Merged
fix memory leak #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XkbFreeClientMap -> XkbFreeKeyboard
|
@jordansissel Tested this patch. It still applies, and it fixes a memory leak. |
|
Odd. Maybe this is a documentation (or implementation) bug in X11? The documentation for XkbGetMap shows:
So it should be "correct" to do what xdo is already doing, and yet, it leaks, as y'all have shown. Weird! I thought about filing something upstream on X11, but it feels like that project is trying to self-terminate so I don't know if it'd be anything they would bother addresseing. |
|
Thanks for this fix, btw! Also thanks to @FascinatedBox for testing <3 |
|
I made some sample code to reproduce this leak using only X11 libraries -- should someone wish to pursue this leak upstream with Xorg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XkbFreeClientMap -> XkbFreeKeyboard