Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep code style & add va_end #372

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Keep code style & add va_end #372

merged 2 commits into from
Jun 30, 2022
+5 −1

Conversation

KT-lcz
Copy link
Contributor

@KT-lcz KT-lcz commented Dec 7, 2021

Use "return EXIT_FAILURE" when failing exit. Add va_end() after va_start()

lichangze added 2 commits December 7, 2021 14:02
style: keep the same code style
66811b1 
Use "return EXIT_FAILURE" when failing exit.

Log: keep the same code style
fix: add va_end() after va_start()
6a3052e 
Before finally taking all the parameters and returning from the function. Need call va_end(). This ensures the correct restoration of the stack.

Log: add va_end() after va_start()
@jordansissel
Copy link
Owner

Ahh, good catch on the missing va_end and +1 to using EXIT_FAILURE instead of 1. Thank you for these improvements :)

@jordansissel jordansissel merged commit ee38f70 into jordansissel:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KT-lcz @jordansissel