Remove unused dependency on libXi #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 6c1db90, the appears_to_be_wayland function was reverted (commented out, really), but the includes and scaffolding for it were left in. This has a couple of effects: - The compiler emits a warning for unused functions - An additional header include is used - The link command is longer, and tries to link to libXi, resulting in overlinking unless -Wl,--as-needed is used The original rationale for keeping it: > I've left the "is on wayland?" detection code that is otherwise now > unused, in case we want it later. The code has gone untouched for several years now, so it is probably time to remove it altogether. In a pinch, it can always be retrieved via `git log`.
|
Sounds good to me. Thank you for the patch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 6c1db90, the appears_to_be_wayland function was reverted (commented out, really), but the includes and scaffolding for it were left in. This has a couple of effects:
The original rationale for keeping it:
The code has gone untouched for several years now, so it is probably time to remove it altogether. In a pinch, it can always be retrieved via
git log.