Fix bug where sync would wait if the mouse didn't need to move.
#464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A case where `xdotool mousemove --sync` is used, and the cursor is already at the requested position, xdotool would wait even though the cursor was already at the current position. This happened because `mousemove --sync` waits for the cursor to move *away* from its current position, but if mousemove is given the position where the cursor already is, then `--sync` will cause it incorrectly to wait. Reproducing this: ``` xdotool mousemove --sync 5 5 # works xdotool mousemove --sync 5 5 # hangs until I move the mouse manually ``` Reported by @MXarko Fixes #463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A case where
xdotool mousemove --syncis used, and the cursor is already at the requested position, xdotool would wait even though the cursor was already at the current position.This happened because
mousemove --syncwaits for the cursor to move away from its current position, but if mousemove is given the position where the cursor already is, then--syncwill cause it incorrectly to wait.Reproducing this:
Reported by @MXarko
Fixes #463