-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge old jqlang/jq master to the latest #2596
Conversation
Something seems to be wrong with the github action definitions here: the windows one failed with an error and the unix ones have hung. |
The action workflow does not trigger because the runner |
32fd8fa
to
c44b97f
Compare
Add link to discord server
c44b97f
to
126ec77
Compare
51bb85b
to
9c4ceae
Compare
9c4ceae
to
55d381e
Compare
@stedolan @itchyny @nicowilliams I got the Linux builds going with no problems. But the macos build failed with https://github.com/jqlang/jq/actions/runs/5114162555/jobs/9194126677#step:6:3160. Do you have any insight into what goes wrong? The Linux clang builds ran okay, though. |
That is a bit strange, error seems to be:
There is an issue related to it #2381 which seems to indicate it has been fixed in newer version of oniguruma. But why did the linux build not complain about it? i would have guessed linux (with gcc?) would complain and fail also on |
Linux build also complains:
But does not use |
MacOS build [fails](https://github.com/jqlang/jq/actions/runs/5114162555/jobs/9194126677#step:6:3160) due to ``` posix.c:94:3: error: implicit declaration of function 'onig_end' is invalid in C99 [-Werror,-Wimplicit-function-declaration] onig_end(); ``` The current `oniguruma` revision 6fa38f4084b448592888ed9ee43c6e90a46b5f5c (15 Mar 2017) lacks the following explicit declaration in src/onigposix.h: ``` ONIG_EXTERN int onig_end P_((void)); ``` This was added to oniguruma in revision 5a24a49d710a9e3bb8ff11d12e1eae5a9f9df40c (8 Sep 2017). Ref: #2381
Thank you! It's an issue with oniguruma's missing onig_end function in the header! I pinned oniguruma to the suggested revision 5a24a49d710a9e3bb8ff11d12e1eae5a9f9df40c as indicated in #2381, and the macos builds are now passing! Weirdly, the Linux clang build is warning while the macos clang build is erroring... |
@owenthereal Some addition info: i can reproduce on macOS 13.3.1 with clang 14.0.3 (clang-1403.0.22.14.1) and the error happens during But i agree that update is probably the best solution, still confused why macOS clang uses -Werror and Linux does not. |
A patch like this seems to fix the diff --git a/src/lexer.l b/src/lexer.l
index 6b9164b..28d281e 100644
--- a/src/lexer.l
+++ b/src/lexer.l
@@ -123,7 +123,7 @@ struct lexer_param;
([a-zA-Z_][a-zA-Z_0-9]*::)*[a-zA-Z_][a-zA-Z_0-9]* { yylval->literal = jv_string(yytext); return IDENT;}
\.[a-zA-Z_][a-zA-Z_0-9]* { yylval->literal = jv_string(yytext+1); return FIELD;}
-[ \n\t]+ {}
+[ \r\n\t]+ {}
. { return INVALID_CHARACTER; } (could possibly also include |
It would be great if someone could have a look at the |
I don't be surprised |
a2e87f7
to
2d367c1
Compare
2d367c1
to
1c28ed6
Compare
Good idea, let's do that. Maybe a mystery for later to figure what differs from the old build env. @owenthereal sounds good to you? |
@itchyny any ideas about the |
Using |
Sounds good to me. Does it require some changes to the test and assertion?
I found actions/checkout#135. I followed the recommendation to turn on LG line endings for all text: 93465d5 |
Yeap something like this should work i think: diff --git a/tests/jq.test b/tests/jq.test
index 2d5c36b..9aa435a 100644
--- a/tests/jq.test
+++ b/tests/jq.test
@@ -1565,7 +1565,7 @@ try (1%.) catch .
jq: error: Division by zero? at <top-level>, line 1:
# Basic numbers tests: integers, powers of two
-[range(-52;52;1)] as $powers | [$powers[]|pow(2;.)|log2] == $powers
+[range(-52;52;1)] as $powers | [$powers[]|pow(2;.)|log2|round] == $powers
null
true You can run the tests with |
Weeee....CI is passing finally! Thank you all for the help! Would you happen to have any more feedback? If not, let's merge. At the moment, the CI only compiles & runs tests. A follow-up PR is needed to publish releases to GH Releases. |
No worries! happy to help and i learned some windows stuff :) Yeap let's merge! the things i'm don't know/are worried about is publish and signing windows binaries (are they built "correctly" etc?). |
🥳 |
After the transfer from stedolan/jq to jqlang/jq, some commits are missing that divert from the older master of stedolan/jq. This is to pull them in: #2594 (comment)