Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overflow exception of the modulo operator (fix #1176) #2629

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Fix overflow exception of the modulo operator (fix #1176) #2629

merged 1 commit into from
Jun 26, 2023

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Jun 25, 2023

This PR fixes #1176. Overflow happens for INTMAX_MIN % (-1).

@itchyny itchyny added the bug label Jun 25, 2023
@itchyny itchyny added this to the 1.7 release milestone Jun 25, 2023
@itchyny itchyny force-pushed the fix-modulo-floating-point-exception branch from ba0d8f4 to 3e8ff6a Compare June 25, 2023 10:51
@itchyny
Copy link
Contributor Author

itchyny commented Jun 26, 2023

Thank you.

@itchyny itchyny merged commit fac5553 into jqlang:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wader wader wader approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.7 release
Development

Successfully merging this pull request may close these issues.

Floating point exception in builtin.c
2 participants
@itchyny @wader