Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Docker image to GitHub Container Registry #2652

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Jul 4, 2023

This PR setups the release workflow to build and push Docker image to GitHub Container Registry. I have already pushed the latest image from debugging branch to https://github.com/jqlang/jq/pkgs/container/jq for anyone interested in the new home of the Docker image. In the next release, the tag 1.7 will be released and also the latest tag will be updated. Based on the request of #2187, I included 4 platforms; amd64, arm64, ppc64le, and s390x. Building the images on QEMU on GitHub Actions is extremely slow, and it took 40 minutes (see this job), but the job is triggered only on releases and we can accept this.
Resolves #2187, resolves #2209, resolves #2377, and resolves #2539.

Copy link
Member

@wader wader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and i agree slow emulated build is probably fine and as jq is not doing anything special per architecture i guess it unlikely to fail if it builds fine for our CI builds

needs: [linux, macos, windows, dist]
if: startsWith(github.event.ref, 'refs/tags/jq-')
needs: [linux, macos, windows, dist, docker]
if: startsWith(github.ref, 'refs/tags/jq-')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.event.ref same as github.ref or was wrong?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are same.

@wader
Copy link
Member

wader commented Jul 4, 2023

Was thinking if we want to do 32bit builds for some architectures but don't find any issues about it so maybe we should skip that for now?

@itchyny
Copy link
Contributor Author

itchyny commented Jul 4, 2023

I found no issue requesting for 32bit architecture images, so I omitted due to my concern about longer build duration.

@itchyny
Copy link
Contributor Author

itchyny commented Jul 4, 2023

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants