Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep releasing executables with legacy names #2951

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Nov 24, 2023

We changed the executable names with explicit architecture name in the 1.7 release, but users still keep downloading with the legacy URLs (ref: #2877). To avoid the same troubles in the coming patch release, I would like to keep releasing executables with legacy names. Based on the download counts, I restored jq-linux64, jq-osx-amd64, and jq-win64.exe.

 $ curl -s https://api.github.com/repos/jqlang/jq/releases/tags/jq-1.7 | jq -r '.assets | sort_by(.download_count)[] | "\(.name): \(.download_count)"'
jq-linux-mipsr6el: 147
jq-linux-mipsr6: 148
jq-linux-powerpc: 148
jq-linux-mips64r6: 151
jq-linux-mips64r6el: 151
jq-linux-riscv64: 153
jq-linux-mipsel: 158
jq-linux-mips64el: 160
jq-linux-s390x: 169
jq-linux-mips64: 175
jq-linux-mips: 181
jq-linux-ppc64el: 184
jq-linux-armel: 224
jq-linux32: 479 # ⭐️
jq-linux-armhf: 602
sha256sum.txt: 845
jq-1.7.zip: 1240
jq-win32.exe: 1546 # ⭐️
jq-windows-i386.exe: 4029
jq-linux-arm64: 10296
jq-linux-i386: 11617
jq-macos-amd64: 13424
jq-macos-arm64: 14485
jq-win64.exe: 36470 # ⭐️
jq-1.7.tar.gz: 41273
jq-linux64: 265654 # ⭐️
jq-windows-amd64.exe: 370257
jq-linux-amd64: 433377
jq-osx-amd64: 548536 # ⭐️

@@ -369,6 +369,9 @@ jobs:
TAG_NAME: ${{ github.ref_name }}
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
cp jq-linux/{jq-linux-amd64,jq-linux64}
cp jq-macos/{jq-macos-amd64,jq-osx-amd64}
cp jq-windows/{jq-windows-amd64.exe,jq-win64.exe}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a comment why this is done?

@wader
Copy link
Member

wader commented Nov 24, 2023

The jq-linux64, jq-osx-amd64, and jq-win64.exe binaries for the 1.7 release where added manually?

@itchyny
Copy link
Contributor Author

itchyny commented Nov 25, 2023

It was added manually in 1.7. #2877 (comment)

@emanuele6 emanuele6 merged commit d14393f into jqlang:master Nov 28, 2023
28 checks passed
@emanuele6
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants