Support mkdocs 1.4.2 and fix its missing breadcrumb #1691
Merged
+667
−444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades us to mkdocs 1.4.2 and fixes the "missing" breadcrumb.
It turns out that the problem was a combination of issues:
aria-label
but that hasn't made it into the mkdocs sourceI'll see about getting that change upstream so we don't have to override their breadcrumbs template and others can benefit from this work, but in the meantime, this PR fixes it in jrnl so we can use the latest mkdocs version.
Checklist
for the same issue.