Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, minica has only been able to generate RSA root keypairs,
and has similarly only been able to load pre-existing PKCS1-formatted
RSA keys from disk.
This change adds support for ECDSA keypairs throughout minica's stack.
It now has a flag which allows users to select between RSA and ECDSA
when creating a new self-signed root. Its internal key generation is
now able to generate either RSA or ECDSA keys, and its key loading is
able to load both RSA and ECDSA keys. Finally, when saving keys to disk,
it now uses the PKCS8 format (which supports multiple kinds of keys)
instead of PKCS1, which only supports RSA. It similarly supports PKCS8
when loading keys from disk.
It still always generates an RSA keypair for the end-entity certificate it
issues.