Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full support for ECDSA roots #50

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Conversation

aarongable
Copy link
Contributor

@aarongable aarongable commented Feb 3, 2021

Historically, minica has only been able to generate RSA root keypairs,
and has similarly only been able to load pre-existing PKCS1-formatted
RSA keys from disk.

This change adds support for ECDSA keypairs throughout minica's stack.
It now has a flag which allows users to select between RSA and ECDSA
when creating a new self-signed root. Its internal key generation is
now able to generate either RSA or ECDSA keys, and its key loading is
able to load both RSA and ECDSA keys. Finally, when saving keys to disk,
it now uses the PKCS8 format (which supports multiple kinds of keys)
instead of PKCS1, which only supports RSA. It similarly supports PKCS8
when loading keys from disk.

It still always generates an RSA keypair for the end-entity certificate it
issues.

@aarongable aarongable changed the title Support loading EC/ECDSA private keys Add full support for ECDSA roots Feb 4, 2021
@jsha jsha merged commit 6c6d1f4 into jsha:master Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants