Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken tests for Node@8 and Node@9 #108

Closed
UlisesGascon opened this issue Mar 14, 2024 · 0 comments · Fixed by #109
Closed

Broken tests for Node@8 and Node@9 #108

UlisesGascon opened this issue Mar 14, 2024 · 0 comments · Fixed by #109

Comments

@UlisesGascon
Copy link
Member

Seems like the current master branch have some broken tests when running Node@8 and Node@9. I realized that with the PR: #107.

Similar error in both cases: https://github.com/jshttp/http-errors/actions/runs/8278069455/job/22650768076#step:10:104, here is an screenshot in case that you can't access to the logs:

Screenshot 2024-03-14 at 10 38 26
This was referenced Mar 14, 2024
Merged
Merged
carpasse added a commit to carpasse/http-errors that referenced this issue Mar 22, 2024
@carpasse
ci: fix tests in node 8 & 9
3c92848 
fix nyc version to 14.1.1 when running tests in node 8 or node 9. nyc 15.x requires a version of yargs package version requires node >=10.

fixes jshttp#108
@carpasse carpasse mentioned this issue Mar 22, 2024
Merged
@carpasse carpasse mentioned this issue Mar 25, 2024
Closed
This was referenced Apr 24, 2024
Merged
Merged
This was referenced May 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: fix tests in node 8 & 9 carpasse/http-errors
1 participant
@UlisesGascon