Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube2iam should discover AWS account ID #13

Closed
tazjin opened this issue Sep 16, 2016 · 5 comments
Closed

kube2iam should discover AWS account ID #13

tazjin opened this issue Sep 16, 2016 · 5 comments

Comments

@tazjin
Copy link

tazjin commented Sep 16, 2016

If no base-role is set, kube2iam should probably discover the AWS account ID and use arn:aws:iam::${AWS_ACCOUNT_ID}:role/ as the default.

@jtblin
Copy link
Owner

jtblin commented Sep 24, 2016

I don't think this should be the default behaviour but maybe if a --discover-role flag is set, we could do that. I am not familiar with this default role, do you have some doc that you can point to?

@ajohnstone
Copy link

Can use the api call on sts to fetch this.

aws sts get-caller-identity
{
    "Account": "<ACCOUNT_ID>", 
    "UserId": "<USER_ID>", 
    "Arn": "arn:aws:iam::<ACCOUNT_ID>:user/<USERNAME>"
}

Would be awesome to add this.

@tazjin
Copy link
Author

tazjin commented Nov 4, 2016

@jtblin That's just the default base ARN at which a role will be located if it's not explicitly put into any path.

@jtblin
Copy link
Owner

jtblin commented Dec 5, 2016

I don't think we'd want to set the default role automatically from a security standpoint, maybe we could do that with (yet) another flag e.g. --discover-default-role or something like that.

jtblin pushed a commit that referenced this issue Apr 24, 2017
* Add base arn auto discovery (#13)
* Add default iam role auto discovery (#63)
@jtblin
Copy link
Owner

jtblin commented Apr 25, 2017

Now released as 0.5.0. Thanks @jescarri for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants