Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not check the pod's deletionTimestamp when determining if a pod is active #203

Merged
merged 1 commit into from
Apr 10, 2019

Conversation

rifelpet
Copy link
Contributor

@rifelpet rifelpet commented Mar 7, 2019

Fixing a regression originating from #173, this was causing nil entries in the pod index which resulted in credentials failing to be issued.

See #178 for more information.

This was causing nil entries in the pod index which resulted in credentials failing to be issued.
See jtblin#178 for more information.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 20.0% when pulling 49a5e5d on rifelpet:deletionTimestamp into 80efbb1 on jtblin:master.

@lbernail
Copy link

lbernail commented Mar 8, 2019

Thanks a lot!

@timm088
Copy link

timm088 commented Mar 12, 2019

@jtblin how do you view this one in current release plan?
Looks to be a fix that keeps #173 related changes around pods 'missing' credentials during terminate

@rifelpet
Copy link
Contributor Author

@jrnt30 was involved in merging and releasing #173 - any chance you can do the same for this?

@lbernail
Copy link

Quick follow-up: We've been running this for about 3 weeks without any issue and everything works fine

Copy link
Collaborator

@jrnt30 jrnt30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. Sorry for taking so long to merge this.

As mentioned previously I am not actively using kube2iam and was unable to consistently reproduce the issue when I had tried before and lost track of this.

Based upon the community feedback that this is working properly going to merge in. Going forward for PRs I will try and get an RC release process in place so we can "move the project forward" but also allow a bake in period for people wanting to use the latest updates in their own environment without touching ":latest"

@jrnt30 jrnt30 merged commit b8eb0a1 into jtblin:master Apr 10, 2019
jessestuart pushed a commit to jessestuart/kube2iam that referenced this pull request Jul 18, 2019
This was causing nil entries in the pod index which resulted in credentials failing to be issued.
See jtblin#178 for more information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants