Add support for externalId as an optional annotation #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3eafc18
to
df22fae
Compare
Jacobious52
approved these changes
Jul 24, 2019
There was a problem hiding this comment.
This looks good to me. I've tested this PR with and without external-id on my lab cluster and the behaviour is as expected. This functionality would be helpful for certain use cases while remaining optional. Thoughts on merging? It would be awesome to be able to cut a release and use the upstream.
|
LGTM, have looked over this with @Jacobious52 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS supports a filtering system via
ExternalIdwhich allows to verify that the system attempting to assume the role is not making a mistake.This adds the support of an externalId annotation (defaults to
iam.amazonaws.com/external-id) so when the prod is created, an externalId can be provided and passed through as part of theassume-roleoperation.