Ignore wildcard interface names in interface check #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtblin
requested changes
Dec 18, 2016
| @@ -33,8 +34,14 @@ func AddRule(appPort, metadataAddress, hostInterface, hostIP string) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // CheckInterfaceExists - validates the interface passed exists for the given system | |||
| // CheckInterfaceExists - validates the interface passed exists for the given system, ignores calico networks | |||
There was a problem hiding this comment.
Nit: it could be other networks as well, it's really about ignoring wildcard characters so i'd make this comment and the one below more generic.
There was a problem hiding this comment.
Changed wording from "ignores calico networks" to "ignores wildcard networks"
ghost
commented
Dec 20, 2016
| func CheckInterfaceExists(hostInterface string) error { | ||
|
|
||
| if strings.Contains(hostInterface, "+") { | ||
| // calico networks ignored |
There was a problem hiding this comment.
Changed from "calico networks ignored" to "wildcard networks ignored"
|
I'm also interested on this |
|
Hey! Just wondering when you'd merge this. I'm currently running a custom version. (I could also help maintain) |
jtblin
approved these changes
Jan 23, 2017
|
Sorry for the lag, I was on annual leave. Thanks for the fix! 👍 |
negz
pushed a commit
to negz/kube2iam
that referenced
this pull request
Feb 26, 2017
* patch to ignore interface names like cali+. jtblin#37 * updates per @jtblin - https://github.com/jtblin/kube2iam/pull/38\#pullrequestreview-13475489
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch to ignore interface names like cali+
What is the problem/feature?
As per #37 calico networks are passed to kube2iam with the 'cali+' notation.
#34 did not take this into consideration.
How did it get fixed/implemented?
CheckInterfaceExiststhat returnsnilif a + is detected