added log statements to make debugging assume-failures easier #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtblin
approved these changes
Feb 23, 2017
negz
pushed a commit
to negz/kube2iam
that referenced
this pull request
Feb 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were running into some issues with assuming roles and had trouble finding the culprit.
The kube2iam container did not have the --base-role-arn flag and we instead added them in the pod manifests explicitly. However, when requesting the role from the store, kube2iam made a check for the entire ARN against the role given in the route, which obviously failed.
While there might be another issue hidden in here, the additional log messages would have made it very obvious what was going on.