Allow roles to be annotated with with the base name or the full ARN #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 26, 2017 19:23
I spent a long time trying to figure out why my role was not being granted despite having annotated my pods. It turns out I had annotated them with the full ARN, and was only able to figure that out via this debug logging.
I had assumed we should use the full ARN, which was causing the role not to be granted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent a long time trying to figure out why my role was not being granted despite having annotated my pods. It turns out I had annotated them with the full ARN. I've expanded the logging a little to help with similar issues in future (typos, etc) and refactored the role check slightly to allow cases where a pod is annotated with the full ARN rather than the role name alone.
Note I have not tested my changes aside from ensuring the code builds.