Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jupyter-server/jupyter_server
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.11.0
Choose a base ref
...
head repository: jupyter-server/jupyter_server
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f4c3889658c1daad1d8966438d1f1b98b3f60641
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Sep 17, 2021

  1. Do not log connection error if the kernel is already shutdown (#584) 

    I had the following error locally:

```
[Voila] Kernel shutdown: c7f832d5-6b46-4f77-9f98-f0b9ca6e7ac8
[Voila] WARNING | Timeout waiting for kernel_info reply from c7f832d5-6b46-4f77-9f98-f0b9ca6e7ac8
[Voila] ERROR | Error opening stream: HTTP 404: Not Found (Kernel does not exist: c7f832d5-6b46-4f77-9f98-f0b9ca6e7ac8)
```

This was because I closed the Voila application before the client could
finish connecting to the kernel.

With this PR, it should shutdown the kernel properly and be silent after
not being able to connect.
    @martinRenou
    martinRenou authored Sep 17, 2021
    Configuration menu
    Copy the full SHA
    ac93dd8 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2021

  1. [BUG]: allow None for min_open_files_limit trait (#587) 

    * allow None as a default for min_open_files_limit

* Missing comma
    @Zsailer
    Zsailer authored Oct 4, 2021
    Configuration menu
    Copy the full SHA
    f4c3889 View commit details
    Browse the repository at this point in the history
Loading