-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise errors on individual problematic extensions when listing extension #1139
Conversation
Codecov ReportBase: 79.87% // Head: 79.93% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1139 +/- ##
==========================================
+ Coverage 79.87% 79.93% +0.05%
==========================================
Files 68 68
Lines 8060 8067 +7
Branches 1598 1599 +1
==========================================
+ Hits 6438 6448 +10
+ Misses 1198 1197 -1
+ Partials 424 422 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I'd say we put the stack trace behind a |
Done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@meeseeksdev please backport to 1.x |
…ic extensions when listing extension
…ic extensions when listing extension) (#1141) Co-authored-by: Zachary Sailer <[email protected]>
Fixes #1134. We can backport this to 1.x once it's merged.
This no longer uses an
ExtensionManager
to load all the extensions as a bunch. Instead, it loads each extension separately, adds a try/catch clause for each individual extension validation, logs the error (if found) for each extension, and doesn't block the validation for other extensions.Here is an example of the new output: