Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import ensure-sync directly from dependence. #1149

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Dec 22, 2022

It seem to me that hiding the fact that ensure_async is from a dependency is counter productive as it adds an unnecessary level of indirection and hide the jupyter_core dependency.

It seem to me that hiding the fact that ensure_async is from a
dependency is counter productive as it adds an unnecessary level of
indirection and hide the jupyter_core dependency.
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 79.97% // Head: 80.00% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (917ff5c) compared to base (2cc810a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1149      +/-   ##
==========================================
+ Coverage   79.97%   80.00%   +0.03%     
==========================================
  Files          68       68              
  Lines        8053     8062       +9     
  Branches     1600     1600              
==========================================
+ Hits         6440     6450      +10     
  Misses       1188     1188              
+ Partials      425      424       -1     
Impacted Files Coverage Δ
jupyter_server/files/handlers.py 85.45% <100.00%> (ø)
jupyter_server/gateway/managers.py 83.01% <100.00%> (+0.04%) ⬆️
jupyter_server/nbconvert/handlers.py 79.09% <100.00%> (ø)
jupyter_server/serverapp.py 80.29% <100.00%> (+0.10%) ⬆️
jupyter_server/services/api/handlers.py 93.22% <100.00%> (ø)
jupyter_server/services/contents/handlers.py 85.78% <100.00%> (+0.07%) ⬆️
jupyter_server/services/contents/manager.py 86.36% <100.00%> (+0.03%) ⬆️
...ter_server/services/kernels/connection/channels.py 58.71% <100.00%> (ø)
jupyter_server/services/kernels/handlers.py 88.88% <100.00%> (+0.15%) ⬆️
jupyter_server/services/kernels/kernelmanager.py 81.48% <100.00%> (+0.05%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Carreau
Copy link
Contributor Author

Carreau commented Dec 22, 2022

jupyter/jupyter_core#326 is related it updates the typing of ensure_async.

@blink1073
Copy link
Contributor

The functions were originally in this repo, we moved them to jupyter_core so we could use them in other libs. Thanks!

@blink1073 blink1073 merged commit 7e26967 into jupyter-server:main Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants