Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for client 8 #1188

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Conversation

blink1073
Copy link
Contributor

  • Use ensure_async() where appropriate
  • Fix type checking

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 80.37% // Head: 80.30% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (fc0400a) compared to base (91c5942).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1188      +/-   ##
==========================================
- Coverage   80.37%   80.30%   -0.08%     
==========================================
  Files          68       68              
  Lines        8149     8149              
  Branches     1605     1605              
==========================================
- Hits         6550     6544       -6     
- Misses       1177     1181       +4     
- Partials      422      424       +2     
Impacted Files Coverage Δ
jupyter_server/gateway/managers.py 83.41% <100.00%> (ø)
jupyter_server/services/kernels/kernelmanager.py 81.57% <100.00%> (-0.61%) ⬇️
...ter_server/services/kernels/connection/channels.py 62.11% <0.00%> (-0.45%) ⬇️
jupyter_server/serverapp.py 79.92% <0.00%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 merged commit b6c1edb into jupyter-server:main Jan 26, 2023
@blink1073 blink1073 deleted the update-ci-client8 branch January 26, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant