Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the extra "or" in front of the second url #1194

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

jonnygrout
Copy link
Contributor

This change was made in #460, but somehow it was not here.

This change was made in jupyter-server#460, but somehow it was not here.
@welcome
Copy link

welcome bot commented Feb 2, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 enabled auto-merge (squash) February 2, 2023 16:47
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 79.14% // Head: 80.39% // Increases project coverage by +1.25% 🎉

Coverage data is based on head (eaf3d40) compared to base (f3fe168).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1194      +/-   ##
==========================================
+ Coverage   79.14%   80.39%   +1.25%     
==========================================
  Files          68       68              
  Lines        8117     8117              
  Branches     1584     1584              
==========================================
+ Hits         6424     6526     +102     
+ Misses       1280     1176     -104     
- Partials      413      415       +2     
Impacted Files Coverage Δ
jupyter_server/serverapp.py 79.94% <100.00%> (+7.80%) ⬆️
jupyter_server/extension/handler.py 67.69% <0.00%> (-1.54%) ⬇️
jupyter_server/gateway/managers.py 83.37% <0.00%> (-0.24%) ⬇️
jupyter_server/base/handlers.py 78.82% <0.00%> (+0.58%) ⬆️
jupyter_server/utils.py 85.46% <0.00%> (+5.81%) ⬆️
jupyter_server/services/shutdown.py 100.00% <0.00%> (+23.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 merged commit 0f9556b into jupyter-server:main Feb 2, 2023
@welcome
Copy link

welcome bot commented Feb 2, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants