Support IPV6 in _find_http_port() #1207
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I try to deploy the jupyterlab server in an environment with IPV6 address, the server fail to start with stack trace like:
This pull request is to solve the problem by detect if the address to listen to is an IPV6 address, if so it construct a socket object with family set to AF_INET6. Otherwise, it fails back to the original code path.
Please consider accepting this patch to make user on IPV6 happier.
Thanks for your attention!