-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redact tokens, etc. in url parameters from request logs #1212
Conversation
replaces `?token=abc123` with `?token=[secret]` in logs
Codecov ReportBase: 80.49% // Head: 80.46% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1212 +/- ##
==========================================
- Coverage 80.49% 80.46% -0.04%
==========================================
Files 68 68
Lines 8117 8134 +17
Branches 1581 1586 +5
==========================================
+ Hits 6534 6545 +11
- Misses 1170 1174 +4
- Partials 413 415 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@meeseeksdev please backport to 1.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…s from request logs replaces `?token=abc123` with `?token=[secret]` in logs (cherry picked from commit 968c56c)
… logs (#1214) replaces `?token=abc123` with `?token=[secret]` in logs (cherry picked from commit 968c56c) Co-authored-by: Min RK <[email protected]>
replaces
?token=abc123
with?token=[secret]
in logs to avoid logging things like auth tokens.adapted from jupyterhub