Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_trailing_slash #346

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

kevin-bates
Copy link
Member

The trailing_slash_test's merge to master introduced a bit of a chicken/egg issue since it came from a branch that didn't use the updated fixtures now derived from pytest-jupyter. This addresses those issues.

@Zsailer
Copy link
Member

Zsailer commented Nov 18, 2020

Thanks, Kevin! Fixes the failing tests in #345.

@Zsailer Zsailer merged commit b2e0895 into jupyter-server:master Nov 18, 2020
@kevin-bates kevin-bates deleted the fix-test-trailing-slash branch January 14, 2021 15:52
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants