Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upgrade packaging dependencies build step #354

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

mwakaba2
Copy link
Member

@mwakaba2 mwakaba2 commented Dec 3, 2020

The "Upgrade Packaging Dependencies" step in workflows/main.yml failed due to

ERROR: Could not install packages due to an EnvironmentError: [WinError 5] Access is denied: 'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pip-uninstall-z_gzya01\\pip.exe'
Consider using the `--user` option or check the permissions.

The fix is to include the --user option.

@codecov-io
Copy link

Codecov Report

Merging #354 (d865e59) into master (f13a22b) will increase coverage by 1.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
+ Coverage   66.33%   67.37%   +1.04%     
==========================================
  Files          55       55              
  Lines        5361     5361              
  Branches      696      696              
==========================================
+ Hits         3556     3612      +56     
+ Misses       1589     1545      -44     
+ Partials      216      204      -12     
Impacted Files Coverage Δ
jupyter_server/base/handlers.py 67.26% <0.00%> (+0.45%) ⬆️
jupyter_server/serverapp.py 62.12% <0.00%> (+0.74%) ⬆️
jupyter_server/services/kernels/kernelmanager.py 62.69% <0.00%> (+0.79%) ⬆️
jupyter_server/services/contents/filemanager.py 69.36% <0.00%> (+2.35%) ⬆️
jupyter_server/terminal/__init__.py 92.00% <0.00%> (+12.00%) ⬆️
jupyter_server/utils.py 70.85% <0.00%> (+15.57%) ⬆️
jupyter_server/__init__.py 100.00% <0.00%> (+38.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f13a22b...d865e59. Read the comment docs.

@Zsailer
Copy link
Member

Zsailer commented Dec 3, 2020

Thanks, @mwakaba2!

@Zsailer Zsailer merged commit ca492c1 into jupyter-server:master Dec 3, 2020
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
…jupyter-server#354)

* thread kernel_name through kernel launch flow and persist in database

* temporarily inline synchronizer changes

* Bump to 0.19.0

* update manifest.in
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Fix upgrade packaging dependencies build step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants