Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Culling: ensure last_activity attr exists before use #365

Merged
merged 2 commits into from
Dec 23, 2020
Merged

Culling: ensure last_activity attr exists before use #365

merged 2 commits into from
Dec 23, 2020

Conversation

afshin
Copy link
Contributor

@afshin afshin commented Dec 22, 2020

Port of jupyter/notebook#5355

Also fixes a race condition in async kernel shutdown and fixes a couple of fixture names that needed a jp_ prefix.

@codecov-io
Copy link

codecov-io commented Dec 22, 2020

Codecov Report

Merging #365 (29db7f9) into master (c2b2c31) will increase coverage by 0.26%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
+ Coverage   69.02%   69.29%   +0.26%     
==========================================
  Files          56       56              
  Lines        6134     6135       +1     
  Branches      804      804              
==========================================
+ Hits         4234     4251      +17     
+ Misses       1646     1616      -30     
- Partials      254      268      +14     
Impacted Files Coverage Δ
jupyter_server/services/kernels/kernelmanager.py 80.23% <83.33%> (+16.74%) ⬆️
jupyter_server/__init__.py 61.53% <0.00%> (-38.47%) ⬇️
jupyter_server/terminal/__init__.py 80.00% <0.00%> (-12.00%) ⬇️
jupyter_server/utils.py 59.79% <0.00%> (-11.06%) ⬇️
jupyter_server/serverapp.py 61.26% <0.00%> (-0.75%) ⬇️
jupyter_server/base/handlers.py 67.49% <0.00%> (-0.46%) ⬇️
jupyter_server/services/contents/filemanager.py 67.02% <0.00%> (-0.22%) ⬇️
jupyter_server/services/contents/fileio.py 75.39% <0.00%> (+1.04%) ⬆️
...upyter_server/services/contents/filecheckpoints.py 63.15% <0.00%> (+1.75%) ⬆️
jupyter_server/services/contents/manager.py 88.32% <0.00%> (+2.39%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2b2c31...29db7f9. Read the comment docs.

Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @afshin!

@Zsailer Zsailer merged commit d0778f9 into jupyter-server:master Dec 23, 2020
Zsailer pushed a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Culling: ensure last_activity attr exists before use
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants