Enable notebook ContentsManager in jupyter_server #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-bates
reviewed
Jan 21, 2021
Co-authored-by: Kevin Bates <[email protected]>
Zsailer
approved these changes
Jan 29, 2021
Zsailer
added a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
* move cookie_secret_file to a non-persistent location, since it should be updated on any server restart * Bump to 0.20.2
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
Enable notebook ContentsManager in jupyter_server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jupyter_server's
contents_manager_classdoesn't accept subclasses of notebook'sContentsManager. While this is the desired behavior for the future of jupyter_server, during this transition phase from notebook to jupyter_server, we should allow notebook's ContentManagers to pass through.This PR relaxes the
contents_manager_classto allow these managers. To do this, newtraittypesare defined and used that check the incoming types/instances against a list of classes.