ExtensionPoint: return True on successful validate() #503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #500, but doesn't actually fix the main issue there (failure to identify extensions that are not importable).
Current situation:
This fixes:
The original error causing failed validation is still swallowed and not logged, which should probably be addressed at some point as well, but at least now values are correct.
This came up when I was trying to write some tests validating an image, where I had:
and was surprised to see that all the extensions were actually invalid.