-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shutdown kernels/terminals on api/shutdown #579
Conversation
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
==========================================
+ Coverage 77.46% 77.51% +0.04%
==========================================
Files 110 110
Lines 10184 10188 +4
Branches 1100 1100
==========================================
+ Hits 7889 7897 +8
+ Misses 1907 1901 -6
- Partials 388 390 +2
Continue to review full report at Codecov.
|
Maybe we should do the same as when shutting down the server with Ctrl-C? jupyter_server/jupyter_server/serverapp.py Lines 2631 to 2639 in 52e1095
|
Co-authored-by: David Brochart <[email protected]>
41815fd
to
4c59367
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @martinRenou - These changes look good and in fact resolve a regression issue.
Fix #578