Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: dir_exists is never awaited #597

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

stdll00
Copy link
Contributor

@stdll00 stdll00 commented Oct 29, 2021

Accoding to https://github.com/jupyter-server/jupyter_server/blob/master/jupyter_server/services/contents/manager.py#L579 , AsyncContentsManager. dir_exists can be async function, but never awaited in test case.

Background: I implemented subclass of AsyncContentsManager, but it not passed this testcase.

@welcome
Copy link

welcome bot commented Oct 29, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2021

Codecov Report

Merging #597 (19aa87b) into master (f944deb) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
- Coverage   77.40%   77.34%   -0.06%     
==========================================
  Files         110      110              
  Lines       10250    10250              
  Branches     1257     1257              
==========================================
- Hits         7934     7928       -6     
- Misses       1918     1926       +8     
+ Partials      398      396       -2     
Impacted Files Coverage Δ
...ter_server/tests/services/contents/test_manager.py 96.95% <100.00%> (ø)
jupyter_server/services/kernels/kernelmanager.py 79.79% <0.00%> (-2.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f944deb...19aa87b. Read the comment docs.

@blink1073 blink1073 added the bug label Oct 29, 2021
@blink1073 blink1073 added this to the 1.11 milestone Oct 29, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073
Copy link
Contributor

Test failures are unrelated (nbconvert tests are flaky).

@blink1073 blink1073 merged commit 29be9c6 into jupyter-server:master Oct 29, 2021
@welcome
Copy link

welcome bot commented Oct 29, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants