Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update some metadata fields, sort deps #675

Merged
merged 3 commits into from
Apr 2, 2022

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Jan 22, 2022

This PR touches up setup.cfg in mostly cosmetic ways:

  • applies whatever sorting my editor does (special casing for pyhon 3.10) for long lists
  • removes the comment about installing the example project
    • downstreams actually use jupyter_server[test] so we can't use relative urls to things we don't distribute

Of particular note that will change how it appears on pypi.io:

  • adds some trove classifiers
  • adds some project URLs
  • changes the home page to be the docs for this project
    • i don't think jupyter server is ever actually mentioned on the website

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2022

Codecov Report

Merging #675 (97dbadd) into main (f6f8c3f) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #675      +/-   ##
==========================================
+ Coverage   70.30%   70.32%   +0.01%     
==========================================
  Files          62       62              
  Lines        7554     7554              
  Branches     1248     1248              
==========================================
+ Hits         5311     5312       +1     
+ Misses       1860     1859       -1     
  Partials      383      383              
Impacted Files Coverage Δ
jupyter_server/services/kernels/kernelmanager.py 79.66% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f8c3f...97dbadd. Read the comment docs.

blink1073
blink1073 previously approved these changes Jan 22, 2022
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

setup.cfg Outdated Show resolved Hide resolved
@blink1073 blink1073 merged commit 36489e3 into jupyter-server:main Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants