-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update flake lock #117
Update flake lock #117
Conversation
in pgadmin-8.2, the command to setup configuration db is `setup-db`
@@ -118,7 +118,7 @@ in | |||
${config.package}/bin/.pgadmin4-setup-wrapped setup | |||
else | |||
# pgadmin-8.2 has .pgadmin4-cli-wrapped | |||
${config.package}/bin/.pgadmin4-cli-wrapped setup | |||
${config.package}/bin/.pgadmin4-cli-wrapped setup-db |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the context for this change? Is services-flake not supported on nixpkgs older to this update anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the PR #115, i made a mistake with the setup command for pgadmin 8.2. since the older nixpkgs had pgadmin 7.5, i could not test this and it got missed.
for older nixpkgs, pgadmin has pgadmin4-setup
executable to setup the configuration db, and for newer nixpkgs, it has pgadmin4-cli
executable to setup the db. so services-flake would support both
if [ -f ${config.package}/bin/.pgadmin4-setup-wrapped ]; then
# pgadmin-7.5 has .pgadmin4-setup-wrapped
${config.package}/bin/.pgadmin4-setup-wrapped setup
else
# pgadmin-8.2 has .pgadmin4-cli-wrapped
${config.package}/bin/.pgadmin4-cli-wrapped setup-db
fi
Let’s understand if we really need this: #117 (comment) Since NixOS/nixpkgs#283330, along with the go backend, grafana frontend is also built from source in nixpkgs. But the offline cache doesn’t support darwin, this can be fixed by overriding it: {
grafana = prev.grafana.overrideAttrs (oa: rec {
offlineCache = oa.offlineCache.overrideAttrs (_ :{
buildPhase = ''
runHook preBuild
export HOME="$(mktemp -d)"
yarn config set enableTelemetry 0
yarn config set cacheFolder $out
yarn config set --json supportedArchitectures.os '[ “linux” “darwin" ]'
yarn config set --json supportedArchitectures.cpu '[ “x64” “arm64" ]'
yarn
runHook postBuild
'';
outputHash = lib.fakeHash;
});
});
} Note: replace the |
Even after fixing the frontend cache, the go backend fails to build. There is an upstream issue open: NixOS/nixpkgs#273998 Looks like it is do with nix: NixOS/nix#9977 |
As a workaround, we can use grafana < 10.2.0 until the case-insensitivity issue is resolved. |
Turns out we can get the latest grafana build on darwin, thanks to: NixOS/nixpkgs#129730 |
CI fails with: |
Until we self-host the runner, hope this helps: actions/runner-images#2875 |
@conscious-puppet @shivaraj-bh What's the original reason for updating flake.lock in this PR? If we revert this, can we avoid having to build grafana on CI and locally? |
some of the packages were old.
if we revert this, then we may not be able to test services flake against current package versions with |
if build is an issue, can we overlay grafana to an older version for darwin? |
This is what I'm trying now |
No description provided.