Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

[mealie] - Support Postgres #1292

Merged
merged 4 commits into from
Dec 3, 2021
Merged

[mealie] - Support Postgres #1292

merged 4 commits into from
Dec 3, 2021

Conversation

larivierec
Copy link
Contributor

Description of the change

Add Postgres DB to mealie -> https://hay-kot.github.io/mealie/documentation/getting-started/install/#docker-compose-with-postgres-beta

Benefits
Postgres instead of sqlite, having the benefit of not having it on each node.

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Title of the PR starts with chart name (e.g. [home-assistant])
  • Variables are documented in the README.md (this can be done with using our helm-docs wrapper ./hack/gen-helm-docs.sh stable <chart>)

@onedr0p onedr0p added the incomplete-docs Categorises a PR for which the documentation has not been updated completely. label Dec 3, 2021
@ghost
Copy link

ghost commented Dec 3, 2021

👋 @larivierec, thanks for taking the time to submit this PR. 🙏🏽

We have noticed that the chart documentation has not been completely updated for this PR.
Could you please make sure that the following items have been updated:

  • version in Chart.yaml has been updated per semver
  • README_CHANGELOG.md.gotmpl contains a summary of the updates for this new version
  • Documentation strings have been added to the keys in values.yaml.

Afterwards you can run ./hack/gen-helm-docs.sh stable <chart> again to update the chart's README.md file.

@onedr0p
Copy link
Member

onedr0p commented Dec 3, 2021

Please also bump the chart version by feature not patch. Thanks!

@larivierec
Copy link
Contributor Author

Will do, realized I also forgot to do what the bot mentioned.

I'll do them both tomorrow at the same time

@ghost ghost added precommit:ok CI status: pre-commit validation successful lint:ok CI status: linting successful install:ok CI status: install successful labels Dec 3, 2021
@larivierec
Copy link
Contributor Author

should be good. let me know if there's anything else i can do.
cheers

@onedr0p
Copy link
Member

onedr0p commented Dec 3, 2021

Please re-read the bot reply above. They way you currently made changes to the README.md will be overwritten because you didn't update the template instead. Make sure you re-run helm-docs afterwards too

@larivierec
Copy link
Contributor Author

larivierec commented Dec 3, 2021

Yes, I believe it is ok now. I added a new commit the README.md is resulting from the following command ./hack/gen-helm-docs.sh stable mealie which I ran from the root however, it was my fault for not having to add it to the template for the changelog, nice spot.

@onedr0p onedr0p merged commit cc39287 into k8s-at-home:master Dec 3, 2021
@onedr0p
Copy link
Member

onedr0p commented Dec 3, 2021

@all-contributors add @larivierec for code

@allcontributors
Copy link
Contributor

@onedr0p

I've put up a pull request to add @larivierec! 🎉

@larivierec larivierec deleted the support-postgres branch May 10, 2022 17:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
incomplete-docs Categorises a PR for which the documentation has not been updated completely. install:ok CI status: install successful lint:ok CI status: linting successful precommit:ok CI status: pre-commit validation successful
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants