Solve UVa problems #29

fatosmorina · 2017-04-07T19:59:33Z

Solutions of some UVa problems

EugenHotaj

Hey fatosmorina, thanks for the PR. Have some overall comments that affect all files.

Once these are answered I'll review more in depth.

EugenHotaj · 2017-04-07T20:15:50Z

UVa/BasicRemains.java

+		}
+	}
+
+	static BufferedReader in;


Here and in other files: global variables should go at the top of the class.

EugenHotaj · 2017-04-07T20:19:39Z

UVa/BasicRemains.java

+	}
+
+	public static void main(String[] args) {
+		try {


Why catch, print, and exit? If there is an error this will happen anyways, no need for the try/catch.

As I mentioned above, I simply used a template and did not make any changes in it.

EugenHotaj · 2017-04-07T20:19:55Z

UVa/BasicRemains.java

+	public static void main(String[] args) {
+		try {
+			solve();
+		} catch (Throwable e) {


Why catch a Throwable instead of an exception?

I simply used a template and did not make any changes in it.

EugenHotaj · 2017-04-07T20:21:39Z

UVa/BasicRemains.java

+		input.close();
+	}
+
+	static int nextInt() throws IOException {


What are this and the next method used for?

I have used a template that a friend sent me. It is a general template that is supposed to be useful and avoid the necessity to repeat the same procedures of getting input and output the result for some common coding challenges that are at Online Judges. This is a similar template with the one that I used
https://github.com/ifhuang/Problems/blob/master/src/codeforces/util/Template7.java

However, in this problem, I had to get a BigInteger as an input, so I used Scanner to get the input from the console, but did not remove the methods of the template that are automatically inserted by the IDE when a new class is created.

I used .close() method of Scanner, because of resource leaks. However, I researched more on this and decided to remove it, as JVM will close it.

fatosmorina · 2017-04-08T07:19:04Z

@EugenHotaj I committed my changes. Please review them.

EugenHotaj

Thanks for the new changes. Took another pass just looking at surface level stuff.

Once you fix these, I'll take an actual look at the logic.

EugenHotaj · 2017-04-08T16:54:21Z

UVa/BasicRemains.java

+		}
+
+		input.close();
+		}


I think you have an extra right bracket here.

I removed the extra bracket as well.

EugenHotaj · 2017-04-08T16:55:13Z

UVa/BasicRemains.java

+10
+789
+ */
+import static java.lang.Integer.parseInt;


Please fix your imports. Only import files you're actually using in the class. This goes for all other files in the PR.

I removed unused classes that were left imported from earlier changes.

EugenHotaj · 2017-04-08T16:55:46Z

UVa/BasicRemains.java

+			System.out.println((p.mod(m)).toString(baseNumber));
+		}
+
+		input.close();


Nit: unnecessary close statement.

I removed this unnecessary close statement.

EugenHotaj · 2017-04-08T16:57:50Z

UVa/JollyJumper.java

+		}
+	}
+
+	public static int findMaximalElement(int[] numbers) {


Please remove this method. It's not being used anywhere AFAICT

EugenHotaj · 2017-04-08T16:59:13Z

UVa/Newspaper.java

+Sample Output
+3.74$*/
+
+package UVa;


Nit: remove package or code will break.

I removed the package declaration.

EugenHotaj · 2017-04-08T16:59:54Z

UVa/PrimeFactors.java

+200 = 2 x 2 x 2 x 5 x 5*/
+
+//https://uva.onlinejudge.org/index.php?option=com_onlinejudge&Itemid=8&page=show_problem&problem=524
+package UVa;


I removed the package declaration.

Doesn't seem like you removed the package declaration here.

I am sorry @EugenHotaj. There were a lot of package declarations, and I thought I removed all of them. I committed the change with the removed package declaration.

EugenHotaj · 2017-04-08T17:00:31Z

UVa/PrimeFactors.java

+			boolean isNegative = false;
+			if (number < 0) {
+				isNegative = true;
+				number = (int) Math.abs(number);


Why are you casting to an int here?

I removed the unnecessary casting that I did.

EugenHotaj · 2017-04-08T17:02:25Z

UVa/PrimeFactors.java

+
+	static void formatOutput(int number, List<Integer> primeFactors, boolean isNegative) {
+		if (isNegative) {
+			number = number * (-1);


Change this to be number *= -1;

I changed it in this shorter form. It looks better now :).

fatosmorina · 2017-04-08T18:33:47Z

@EugenHotaj I committed these changes. Please review them.

EugenHotaj

Thanks for the PRs Fatos. I'll leave it to @kdn251 to review correctness of the algos before he meges. Looks good from a readability standpoint after you fix this last comment.

EugenHotaj · 2017-04-12T02:37:19Z

UVa/BasicRemains.java

@@ -0,0 +1,41 @@
+
+/*
+Given a base b and two non-negative base b integers


Could you please fix these comments to follow either javadoc style or multiline comment stye:

/** * commet here * comment here */

Note that the only difference between a javadoc and a multiline comment is that a javadoc starts with /** while a comment starts with /*

I fixed the comments and used javadoc. Actually, I intentionally used that type of commenting in the beginning, so that people who are struggling to solve these problems can find these solutions a lot easier by searching with the problem descriptions. Adding asterisks or slashes in the beginning of lines can make it difficult for other people to find these solutions by simply using the problem description as a Google search query.

You actually make a very good point. I'll leave it up to @kdn251 to have the final say on if he wants to have a consistent style or "searchability".

fatosmorina · 2017-04-12T05:04:09Z

@EugenHotaj I am glad and grateful to be able to contribute to this very helpful repository. As for the correctness, all these solutions of these problems have been accepted as correct solutions by the Online Judge at https://uva.onlinejudge.org/. @kdn251 may verify them :).

EugenHotaj · 2017-04-12T12:15:58Z

UVa/BasicRemains.java

@@ -0,0 +1,44 @@
+
+/**
+*Given a base b and two non-negative base b integers


Nit: by the way, for the comment to really follow javadoc style it should be in this form:

/** * <- all asterisks line up with the first asterisk * <- one space between an asterisk and the first character of a line */

Up to you if you want to make this change or not.

kdn251 · 2017-04-12T18:57:25Z

Hi @fatosmorina, thank you so much for the PR and thanks @EugenHotaj for reviewing the commits. I have a few notes before I can merge your code...

-Missing import statements for JollyJumpers (please add the S to the title of the class)
-TLE for The Last Non-Zero Digit (I imagine this has to do with you using Scanner as oppose to BufferedReader)
-I receive a runtime error for Prime Factors, also please rename generatePrimeNumbers function to sieveOfEratosthenes so people understand how you're generating the primes

Looking forward to your changes!

fatosmorina · 2017-04-12T19:57:26Z

Hi @kdn251
Thank you too for taking the time to review my changes. I have committed the changes that you asked. I submitted LastNonZeroDigit and got it accepted in UVa. Can you please try again?

kdn251 · 2017-04-12T20:50:41Z

Anytime! I just resubmitted and it worked. My mistake I believe I was submitting it for the wrong problem! Now as just one last minor correction could you just change the name of the LastNonZeroDigit file to TheLastNonZeroDigit please. I would just like to stay consistent with the naming conventions. Thank you!

fatosmorina · 2017-04-13T02:37:17Z

@kdn251 I renamed the file. You can have look at it yourself. Thanks.

kdn251 · 2017-04-13T02:47:36Z

Looks great, I'm merging the changes now. Thank you again for your contribution @fatosmorina!

fatosmorina · 2017-04-13T04:36:01Z

Thank you too @kdn251 . It is my pleasure. I am planning to continue with further contributions.

fatosmorina added 12 commits April 6, 2017 20:43

Solve PrimeFactors

bbd4297

Solve JollyJumper:

0fdb9fd

Solve Newspaper

339d327

Add Newspaper problem description as a comment

e5a6ec7

Add .idea in git ignore to ignore IntelliJ files

6b4e8b7

Remove specific project customizations

8822d8d

JollyJumper

fac9c6b

Add problem description

34e02e3

Add PrimeFactors probilem description

50c0262

Solve BasicRemains

7fa5517

Solve LastNonZeroDigit

c6a08f1

Remove .classpath .project .settings

6548ed7

EugenHotaj requested changes Apr 7, 2017

View reviewed changes

fatosmorina added 5 commits April 8, 2017 08:44

Remove unused methods from BasicRemains.java

266a084

Remove unused methods from JollyJumper

b536d7e

Refactor LastNonZeroDigit

e327f0f

Refactor Newspaper

2c423fd

Refactor PrimeFactors

19e2974

EugenHotaj requested changes Apr 8, 2017

View reviewed changes

fatosmorina added 6 commits April 8, 2017 20:21

Remove unused libraries at BasicRemains

80b7673

Remove unused libraries at JollyJumper

787483d

Remove package declaration

9d2d330

remove unused method at JollyJumper

8005d6c

Do not cast Math.abs into int

c340ffd

Turn number = number * (-1) into short form

c754b98

EugenHotaj requested changes Apr 12, 2017

View reviewed changes

fatosmorina added 2 commits April 12, 2017 06:32

Remove package declaration at PrimeFactors

e4af65c

Use java doc commenting style at JollyJumper

592bf7b

fatosmorina added 7 commits April 12, 2017 06:46

Add problem URL at LastNonZeroDigit

0295a70

Use java doc commenting style at Newspaper

de847ee

Add problem URL at Newspaper

f3b7e12

Use java doc commenting style at PrimeFactors

2b9f98a

Set the asterix to a new line

e8b7c4f

Use java doc commenting style at BasicRemains

e5d379e

Add problem URL at BasicRemains

e2d2f12

EugenHotaj approved these changes Apr 12, 2017

View reviewed changes

EugenHotaj reviewed Apr 12, 2017

View reviewed changes

fatosmorina added 5 commits April 12, 2017 14:32

Set Java doc style of comments

ffa3f46

Set Java doc style of comments

2716e45

Set Java doc style of comments

22857e5

Set Java doc style of comments

8d4b4df

Set Java doc style of comments

cc6bbc0

fatosmorina added 6 commits April 12, 2017 21:25

Rename JollyJumper to JollyJumpers

86c485f

Add missing imports at JollyJumpers

1148e29

Remove unused import

9b0469d

Rename method from generatePrimeFactors to sieveOfEratosthenes

0882b45

Rename method from generatePrimeFactors to sieveOfEratosthenes

da10d96

Optimize PrimeFactors

8bcde5e

fatosmorina added 2 commits April 13, 2017 04:33

Rename LastNonZeroDigit to TheLastNonZeroDigit

a816d98

Rename LastNonZeroDigit to TheLastNonZeroDigit

1be6f19

kdn251 merged commit 8121b77 into kdn251:master Apr 13, 2017

		@@ -0,0 +1,41 @@

		/*
		Given a base b and two non-negative base b integers

		@@ -0,0 +1,44 @@

		/**
		*Given a base b and two non-negative base b integers

Solve UVa problems #29

Solve UVa problems #29

Conversation

fatosmorina commented Apr 7, 2017

EugenHotaj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fatosmorina commented Apr 8, 2017

EugenHotaj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fatosmorina commented Apr 8, 2017

EugenHotaj left a comment

Choose a reason for hiding this comment

EugenHotaj Apr 12, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EugenHotaj Apr 12, 2017 • edited Loading

Choose a reason for hiding this comment

fatosmorina commented Apr 12, 2017 • edited by EugenHotaj Loading

EugenHotaj Apr 12, 2017 • edited Loading

Choose a reason for hiding this comment

kdn251 commented Apr 12, 2017

fatosmorina commented Apr 12, 2017

kdn251 commented Apr 12, 2017

fatosmorina commented Apr 13, 2017

kdn251 commented Apr 13, 2017

fatosmorina commented Apr 13, 2017

EugenHotaj Apr 12, 2017 •

edited

Loading

EugenHotaj Apr 12, 2017 •

edited

Loading

fatosmorina commented Apr 12, 2017 •

edited by EugenHotaj

Loading

EugenHotaj Apr 12, 2017 •

edited

Loading