-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Image Pull Secrets to Deployment Template #758
Conversation
@rusenask hi! Could you please review these changes? |
@gelugu this change only allows to pull the KEEL image itself from a private registry, but it's not about supporting having private registries in the actual workloads? |
@david-garcia-garcia hi!
But we need to specify |
@david-garcia-garcia, sorry, I did not understand the question at first. Yes, we only need to pull the KEEL image from private registries. |
@david-garcia-garcia hi! can you please review this PR? it seems like a small change, but would really help us to move on with our security tasks |
This would be helpful to run keel in airgapped enviroments (with the provided Helm Chart) |
Minimal refactor and fixes: * Add dockerignore file to re-use already built images * Add Image Pull Secrets to Deployment Template (keel-hq#758) * Update Go Version to 1.21 (keel-hq#751) * Added GithubWorkflow to use the self-hosted Github repository as a Helm Chart Repository through Github Pages * Create debug container to allow GO remote debugging * Add integration with Azure Pipelines * Add compose files to setup local development containers
Minimal refactor and fixes: * Add dockerignore file to re-use already built images * Add Image Pull Secrets to Deployment Template (#758) * Update Go Version to 1.21 (#751) * Added Github Workflow to use the Github repository as a Helm Chart Repository through Github Pages * Create debug container to allow GO remote debugging * Add integration with Azure Pipelines * Add compose files to setup local development containers
@gelugu I absorbed your PR as part of an initial micro refactor. Can you please test new Helm Chart release? Note that the URL for the helm repository has changed:
|
Should be fixed in next release. |
I've checked, everything is working. Thnx! |
This feature allows specifying image pull secrets in the
values.yaml
file, which are then used in thedeployment.yaml
file to pull images from private registries.The change is backward compatible and follows the existing code style.
Changes include:
values.yaml
to includeimagePullSecrets
as a list of secrets.deployment.yaml
to includeimagePullSecrets
underspec.template.spec
. TheimagePullSecrets
field is only presented if at least one secret is defined.README.md
file to include the newimagePullSecrets
configuration option.Please review and provide any feedback.