Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Image Pull Secrets to Deployment Template #758

Closed
wants to merge 2 commits into from

Conversation

gelugu
Copy link

@gelugu gelugu commented Jun 20, 2024

This feature allows specifying image pull secrets in the values.yaml file, which are then used in the deployment.yaml file to pull images from private registries.

The change is backward compatible and follows the existing code style.

Changes include:

  • Modified values.yaml to include imagePullSecrets as a list of secrets.
  • Updated deployment.yaml to include imagePullSecrets under spec.template.spec. The imagePullSecrets field is only presented if at least one secret is defined.
  • Updated the README.md file to include the new imagePullSecrets configuration option.

Please review and provide any feedback.

@gelugu
Copy link
Author

gelugu commented Jun 24, 2024

@rusenask hi! Could you please review these changes?

@david-garcia-garcia
Copy link
Collaborator

@gelugu this change only allows to pull the KEEL image itself from a private registry, but it's not about supporting having private registries in the actual workloads?

@gelugu
Copy link
Author

gelugu commented Jul 19, 2024

@david-garcia-garcia hi!
We can rewrite image.repository:

image:
  repository: our.private.registry/keelhq/keel

But we need to specify imagePullSecrets.

@gelugu
Copy link
Author

gelugu commented Jul 22, 2024

@david-garcia-garcia, sorry, I did not understand the question at first. Yes, we only need to pull the KEEL image from private registries.

@gelugu
Copy link
Author

gelugu commented Sep 23, 2024

@david-garcia-garcia hi! can you please review this PR? it seems like a small change, but would really help us to move on with our security tasks

@stieler-it
Copy link

This would be helpful to run keel in airgapped enviroments (with the provided Helm Chart)

david-garcia-garcia added a commit to david-garcia-garcia/keel that referenced this pull request Nov 4, 2024
david-garcia-garcia added a commit to david-garcia-garcia/keel that referenced this pull request Nov 4, 2024
Minimal refactor and fixes:

* Add dockerignore file to re-use already built images
* Add Image Pull Secrets to Deployment Template (keel-hq#758)
* Update Go Version to 1.21 (keel-hq#751)
* Added GithubWorkflow to use the self-hosted Github repository as a Helm Chart Repository through Github Pages
* Create debug container to allow GO remote debugging
* Add integration with Azure Pipelines
* Add compose files to setup local development containers
@david-garcia-garcia david-garcia-garcia mentioned this pull request Nov 4, 2024
david-garcia-garcia added a commit that referenced this pull request Nov 4, 2024
Minimal refactor and fixes:

* Add dockerignore file to re-use already built images
* Add Image Pull Secrets to Deployment Template (#758)
* Update Go Version to 1.21 (#751)
* Added Github Workflow to use the Github repository as a Helm Chart Repository through Github Pages
* Create debug container to allow GO remote debugging
* Add integration with Azure Pipelines
* Add compose files to setup local development containers
@david-garcia-garcia
Copy link
Collaborator

@gelugu I absorbed your PR as part of an initial micro refactor. Can you please test new Helm Chart release? Note that the URL for the helm repository has changed:

  repository = "https://keel-hq.github.io/keel"
  chart      = "keel"
  version    = "v1.0.4"

@david-garcia-garcia
Copy link
Collaborator

Should be fixed in next release.

@gelugu
Copy link
Author

gelugu commented Nov 12, 2024

I've checked, everything is working. Thnx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants