-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time for a new release? #760
Comments
The OpenHub project indicators on https://openhub.net/p/ffmpeg-python have some worrying observations. |
The last ffmpeg-python module release was in 2019[1], upstream seem to be unavailable[2] and the project development seem to have stagnated[3]. As the features it provide is trivial to replace using the Python native subprocess module, drop the dependency. [1] <URL: https://github.com/kkroening/ffmpeg-python/tags > [2] <URL: kkroening/ffmpeg-python#760 > [3] <URL: https://openhub.net/p/ffmpeg-python >
The request for packaging of ffmpeg-python in Debian is https://bugs.debian.org/1034286 . Because of the amount of response here as well the number of open issues and pull requests I decided to not push forward to get ffmpeg-python in Debian and instead adjust OpenAI Whisper to work without it. |
* Drop ffmpeg-python dependency and call ffmpeg directly. The last ffmpeg-python module release was in 2019[1], upstream seem to be unavailable[2] and the project development seem to have stagnated[3]. As the features it provide is trivial to replace using the Python native subprocess module, drop the dependency. [1] <URL: https://github.com/kkroening/ffmpeg-python/tags > [2] <URL: kkroening/ffmpeg-python#760 > [3] <URL: https://openhub.net/p/ffmpeg-python > * Rewrote to use subprocess.run() instead of subprocess.Popen(). * formatting changes * formatting update * isort fix * Error checking * isort 🤦🏻 * flake8 fix * minor spelling changes --------- Co-authored-by: Jong Wook Kim <[email protected]>
* Drop ffmpeg-python dependency and call ffmpeg directly. The last ffmpeg-python module release was in 2019[1], upstream seem to be unavailable[2] and the project development seem to have stagnated[3]. As the features it provide is trivial to replace using the Python native subprocess module, drop the dependency. [1] <URL: https://github.com/kkroening/ffmpeg-python/tags > [2] <URL: kkroening/ffmpeg-python#760 > [3] <URL: https://openhub.net/p/ffmpeg-python > * Rewrote to use subprocess.run() instead of subprocess.Popen(). * formatting changes * formatting update * isort fix * Error checking * isort 🤦🏻 * flake8 fix * minor spelling changes --------- Co-authored-by: Jong Wook Kim <[email protected]>
* Drop ffmpeg-python dependency and call ffmpeg directly. The last ffmpeg-python module release was in 2019[1], upstream seem to be unavailable[2] and the project development seem to have stagnated[3]. As the features it provide is trivial to replace using the Python native subprocess module, drop the dependency. [1] <URL: https://github.com/kkroening/ffmpeg-python/tags > [2] <URL: kkroening/ffmpeg-python#760 > [3] <URL: https://openhub.net/p/ffmpeg-python > * Rewrote to use subprocess.run() instead of subprocess.Popen(). * formatting changes * formatting update * isort fix * Error checking * isort 🤦🏻 * flake8 fix * minor spelling changes --------- Co-authored-by: Jong Wook Kim <[email protected]>
@petterreinholdtsen Should we be using this library instead? https://github.com/jonghwanhyeon/python-ffmpeg Have you had time to review the library by jonghwanhyeon? Guix contributor, Parnikkapore, recently submitted a patch to GNU Guix for this library but the latest release has some incompatibilities with our latest packaged CPython requiring patching imports: https://issues.guix.gnu.org/64732#7 I wonder if we should just use a more up to date |
(It's a me! 😀) AFAICT this library is primarily a more friendly surface syntax for FFmpeg filtergraphs (read: a way to write filtergraphs more python-ically); neither python-ffmpeg nor imageio-ffmpeg fulfills this task AFAICT. Whisper does not need to dynamically build up a filtergraph, so it can hard-code the arguments. Unfortunately for me, r128gain does. |
For any future souls surfacing this in a search, ffmpegio has a filtergraph builder and is still maintained as of this writing. Not as perused as this one though. |
@parnikkapore Hi! Reading through the docs for python-ffmpeg, I can see how python-ffmpeg doesn't have the API niceties that @parnikkapore I think we should choose a later commit of Let's continue the thread over at #64732 on the mumi bug tracker. |
Nice |
* Drop ffmpeg-python dependency and call ffmpeg directly. The last ffmpeg-python module release was in 2019[1], upstream seem to be unavailable[2] and the project development seem to have stagnated[3]. As the features it provide is trivial to replace using the Python native subprocess module, drop the dependency. [1] <URL: https://github.com/kkroening/ffmpeg-python/tags > [2] <URL: kkroening/ffmpeg-python#760 > [3] <URL: https://openhub.net/p/ffmpeg-python > * Rewrote to use subprocess.run() instead of subprocess.Popen(). * formatting changes * formatting update * isort fix * Error checking * isort 🤦🏻 * flake8 fix * minor spelling changes --------- Co-authored-by: Jong Wook Kim <[email protected]>
* Drop ffmpeg-python dependency and call ffmpeg directly. The last ffmpeg-python module release was in 2019[1], upstream seem to be unavailable[2] and the project development seem to have stagnated[3]. As the features it provide is trivial to replace using the Python native subprocess module, drop the dependency. [1] <URL: https://github.com/kkroening/ffmpeg-python/tags > [2] <URL: kkroening/ffmpeg-python#760 > [3] <URL: https://openhub.net/p/ffmpeg-python > * Rewrote to use subprocess.run() instead of subprocess.Popen(). * formatting changes * formatting update * isort fix * Error checking * isort 🤦🏻 * flake8 fix * minor spelling changes --------- Co-authored-by: Jong Wook Kim <[email protected]>
Is repository still being maintained? |
* Drop ffmpeg-python dependency and call ffmpeg directly. The last ffmpeg-python module release was in 2019[1], upstream seem to be unavailable[2] and the project development seem to have stagnated[3]. As the features it provide is trivial to replace using the Python native subprocess module, drop the dependency. [1] <URL: https://github.com/kkroening/ffmpeg-python/tags > [2] <URL: kkroening/ffmpeg-python#760 > [3] <URL: https://openhub.net/p/ffmpeg-python > * Rewrote to use subprocess.run() instead of subprocess.Popen(). * formatting changes * formatting update * isort fix * Error checking * isort 🤦🏻 * flake8 fix * minor spelling changes --------- Co-authored-by: Jong Wook Kim <[email protected]>
I notice the last release of ffmpeg-python was released in 2019. Perhaps it is time to wrap up a new release? Is this library still being maintained? The number of open pull requests and issues make me wonder. If it is, I would love to see this library distributed from the Debian project to become available in all the Linux distributions derived from Debian, like Ubuntu and Kali. Is this something you would be interested in making happen?
The text was updated successfully, but these errors were encountered: