rename fix apply

konvajs · May 16, 2024 · 7d5ba3e · 7d5ba3e
1 parent 2587e07
commit 7d5ba3e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/Global.ts b/src/Global.ts
@@ -90,6 +90,7 @@ export const Konva = {
   _mouseDblClickPointerId: null,
   _touchDblClickPointerId: null,
   _pointerDblClickPointerId: null,
+  _fixTextRendering: false,
 
   /**
    * Global pixel ratio configuration. KonvaJS automatically detect pixel ratio of current device.

diff --git a/src/shapes/Text.ts b/src/shapes/Text.ts
@@ -205,10 +205,11 @@ export class Text extends Shape<TextConfig> {
     direction = direction === INHERIT ? context.direction : direction;
 
     var translateY = lineHeightPx / 2;
-    const baseline = this.textBaseline();
-    if (baseline === 'alphabetic') {
+    var baseline = MIDDLE;
+    if (Konva._fixTextRendering) {
       var metrics = this.measureSize('M'); // Use a sample character to get the ascent
 
+      baseline = 'alphabetic';
       translateY =
         (metrics.fontBoundingBoxAscent - metrics.fontBoundingBoxDescent) / 2 +
         lineHeightPx / 2;
@@ -655,7 +656,6 @@ export class Text extends Shape<TextConfig> {
 
   direction: GetSet<string, this>;
   fontFamily: GetSet<string, this>;
-  textBaseline: GetSet<string, this>;
   fontSize: GetSet<number, this>;
   fontStyle: GetSet<string, this>;
   fontVariant: GetSet<string, this>;
@@ -752,8 +752,6 @@ Factory.addGetterSetter(Text, 'direction', INHERIT);
  */
 Factory.addGetterSetter(Text, 'fontFamily', 'Arial');
 
-Factory.addGetterSetter(Text, 'textBaseline', MIDDLE);
-
 /**
  * get/set font size in pixels
  * @name Konva.Text#fontSize

diff --git a/test/sandbox.html b/test/sandbox.html
@@ -30,6 +30,8 @@
     <script type="module">
       import Konva from '../src/index.ts';
 
+      Konva._fixTextRendering = true;
+
       var stageWidth = window.innerWidth;
       var stageHeight = window.innerHeight;