add ingress for model access #2536
Conversation
|
Thanks for the PR @leodag! This seems reasonable to me! Could you test the PR using cc @jessegoodier When you return, thoughts on the changes in this PR? |
|
I've tested the template with This is also basically just a copy of This made me look at cost-analyzer-ingress template again and I noticed I was missing a small part of it (handling labels), I'll add that too. |
…l/main * commit '16f7bafcfdfb74aab2c2b41a0046a4e476f7114b': (85 commits) fix description link (#2626) Issue templating system (#2595) reduce issue stale period to 230 days (#2625) add stale bot (#2597) Update Network Costs to 0.17.0 revised comment default to false, rename env var to match kcm Add note about supporting IDR currency to values.yaml (#2055) Bump actions/checkout from 4.0.0 to 4.1.0 (#2604) updated grafana dashboard to match queries used by kubecost (#2590) skip online validation helm value Add support for busybox image path (#2387) Revise comments for FederatedETL configs for clarity/readability (#2598) copy README (mostly) from root (#2591) add ingress for model access (#2536) fix(cost-analyzer): Set remoreWrite env variables only when enabled (#2578) remove unused check for Nodes (#2586) add and/or fix templating of global.podAnnotations (#2587) Re-add the `useMultiClusterDB` helm config (#2585) Update AMP endpoint's path in config (#2575) ... # Conflicts: # cost-analyzer/templates/cost-analyzer-deployment-template.yaml # cost-analyzer/values.yaml
What does this PR change?
This adds an optional kubecostModel.ingress option so that it can be configured separately from the frontend. This comes from a need in my company to expose the model through a basic auth ingress so that it can be accessed programatically, while the frontend is handled differently.
Does this PR rely on any other PRs?
No.
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Adds an additional option (defaulting off) to have an ingress that points directly to the model container.
Links to Issues or tickets this PR addresses or fixes
I haven't created any issues for this, should I create one?
What risks are associated with merging this PR? What is required to fully test this PR?
Should be a pretty simple change; one deployment with it enabled and disabled should be enough IMO.
How was this PR tested?
Tested locally and backported with no changes o the version currently in use by my company (1.102.2), which is deployed in my company's test cluster.
Have you made an update to documentation? If so, please provide the corresponding PR.
Added
kubecostModel.ingressto the READMEThis is my first contribution to the project, if there's any additional information or changes needed, do comment!