Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue templating system #2595

Merged
merged 8 commits into from
Oct 5, 2023

Conversation

chipzoller
Copy link
Collaborator

Signed-off-by: chipzoller [email protected]

What does this PR change?

This PR makes the following changes/additions based upon an internal discussion regarding how best to accept issues to Kubecost.

  • Modifies the existing feature request template.
  • Introduces a new bug template.
  • Introduces a new issue guidelines file to help route users to the correct location based upon their needs.

Does this PR rely on any other PRs?

No

How does this PR impact users? (This is the kind of thing that goes in release notes!)

Links to Issues or tickets this PR addresses or fixes

What risks are associated with merging this PR? What is required to fully test this PR?

N/A

How was this PR tested?

N/A

Have you made an update to documentation? If so, please provide the corresponding PR.

N/A

Signed-off-by: chipzoller <[email protected]>
@chipzoller
Copy link
Collaborator Author

This is a first stab at the changes discussed yesterday. Note that the new repository here is only a placeholder for now pending acceptance of this PR. It will be built out to accommodate only Kubecost application feature requests if accepted.

Signed-off-by: chipzoller <[email protected]>
Signed-off-by: chipzoller <[email protected]>
Signed-off-by: chipzoller <[email protected]>
Copy link
Contributor

@dwbrown2 dwbrown2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!!!

.github/ISSUE_TEMPLATE/bug.yaml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yaml Outdated Show resolved Hide resolved
ISSUE_GUIDELINES.md Outdated Show resolved Hide resolved
Signed-off-by: chipzoller <[email protected]>
@chipzoller
Copy link
Collaborator Author

Looking for reviews here @dwbrown2, @kwombach12, @thomasvn, @teevans, @jcharcalla, @jessegoodier

ISSUE_GUIDELINES.md Outdated Show resolved Hide resolved
ISSUE_GUIDELINES.md Outdated Show resolved Hide resolved
ISSUE_GUIDELINES.md Outdated Show resolved Hide resolved
Signed-off-by: chipzoller <[email protected]>
ISSUE_GUIDELINES.md Show resolved Hide resolved
Signed-off-by: chipzoller <[email protected]>
Copy link

@kwombach12 kwombach12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chipzoller chipzoller merged commit 36dd727 into kubecost:develop Oct 5, 2023
8 checks passed
@chipzoller chipzoller deleted the issue-template-design branch October 5, 2023 15:01
ameijer added a commit that referenced this pull request Oct 6, 2023
…l/main

* commit '16f7bafcfdfb74aab2c2b41a0046a4e476f7114b': (85 commits)
  fix description link (#2626)
  Issue templating system (#2595)
  reduce issue stale period to 230 days (#2625)
  add stale bot (#2597)
  Update Network Costs to 0.17.0
  revised comment
  default to false, rename env var to match kcm
  Add note about supporting IDR currency to values.yaml (#2055)
  Bump actions/checkout from 4.0.0 to 4.1.0 (#2604)
  updated grafana dashboard to match queries used by kubecost (#2590)
  skip online validation helm value
  Add support for busybox image path (#2387)
  Revise comments for FederatedETL configs for clarity/readability (#2598)
  copy README (mostly) from root (#2591)
  add ingress for model access (#2536)
  fix(cost-analyzer): Set remoreWrite env variables only when enabled (#2578)
  remove unused check for Nodes (#2586)
  add and/or fix templating of global.podAnnotations (#2587)
  Re-add the `useMultiClusterDB` helm config (#2585)
  Update AMP endpoint's path in config (#2575)
  ...

# Conflicts:
#	cost-analyzer/templates/cost-analyzer-deployment-template.yaml
#	cost-analyzer/values.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants